Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-19341

commentfield.vm should not manipulate the XWikiComment class

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: In Progress
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 12.6
    • Fix Version/s: None
    • Component/s: Flamingo Skin
    • Labels:
    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Pull Request Status:
      Awaiting Committer feedback
    • Similar issues:

      Description

      commentfield.vm is in charge of generating a new editor field on demand for the comments.
      It needs to take into account the wiki and user editor preferences as well as the settings of the XWiki.XWikiComments.comment field for its rendering
      In addition, in case of error when submitting a captcha, or when editing a comment, the submitted content must be displayed again to the user.
      The current approach of the script is based on XClass manipulation that

      • complex
      • can cause strange race conditions

      It's easier to directly use the edit script services to generate editors matching the requirements listed above.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mleduc Manuel Leduc
              Reporter:
              mleduc Manuel Leduc
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Date of First Response: