Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-23236

Using the office macro inside the async macro isn't possible anymore

    XMLWordPrintable

Details

    • Unknown

    Description

      Steps to reproduce:

      1. Enable/start the office server.
      2. Attach an office file to a page (e.g., the main page).
      3. Add an office macro inside an async macro using the wiki editor, e.g. 
        {{async}}{{office reference="Main.WebHome@Workshop 1.ods"/}}{{/async}} 

        Make sure you use an absolute reference.

      4. View the page.

      Expected result:

      The office file is displayed.

      Actual result:

      An error is displayed with the following stack trace:

      org.xwiki.rendering.macro.MacroExecutionException: Failed to view office attachment.
       at org.xwiki.rendering.internal.macro.office.OfficeMacro.execute(OfficeMacro.java:114)
       at org.xwiki.rendering.internal.macro.office.OfficeMacro.execute(OfficeMacro.java:55)
       at org.xwiki.rendering.internal.transformation.macro.MacroTransformation.transform(MacroTransformation.java:309)
       at org.xwiki.rendering.internal.transformation.DefaultRenderingContext.transformInContext(DefaultRenderingContext.java:183)
       at
       
      org.xwiki.rendering.internal.transformation.DefaultTransformationManager.performTransformations(DefaultTransformationManager.java:88)
       at org.xwiki.rendering.async.internal.block.AbstractBlockAsyncRenderer.transform(AbstractBlockAsyncRenderer.java:74)
       at org.xwiki.rendering.async.internal.block.DefaultBlockAsyncRenderer.tranform(DefaultBlockAsyncRenderer.java:156)
       at org.xwiki.rendering.async.internal.block.DefaultBlockAsyncRenderer.execute(DefaultBlockAsyncRenderer.java:139)
       at org.xwiki.rendering.async.internal.block.AbstractBlockAsyncRenderer.render(AbstractBlockAsyncRenderer.java:157)
       at org.xwiki.rendering.async.internal.block.AbstractBlockAsyncRenderer.render(AbstractBlockAsyncRenderer.java:54)
       at org.xwiki.rendering.async.internal.AsyncRendererJob.runInternal(AsyncRendererJob.java:109)
       at org.xwiki.job.AbstractJob.runInContext(AbstractJob.java:243)
       at org.xwiki.job.AbstractJob.run(AbstractJob.java:220)
       at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
       at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
       at java.base/java.lang.Thread.run(Thread.java:829)
      Caused by: java.lang.NullPointerException
       at
       
      org.xwiki.store.filesystem.internal.DefaultTemporaryAttachmentSessionsManager.getOrCreateSession(DefaultTemporaryAttachmentSessionsManager.java:77)
       at
       
      org.xwiki.store.filesystem.internal.DefaultTemporaryAttachmentSessionsManager.getUploadedAttachment(DefaultTemporaryAttachmentSessionsManager.java:119)
       at org.xwiki.store.TemporaryAttachmentSessionsManager.getUploadedAttachment(TemporaryAttachmentSessionsManager.java:88)
       at org.xwiki.office.viewer.internal.DefaultOfficeResourceViewer.getView(DefaultOfficeResourceViewer.java:377)
       at org.xwiki.office.viewer.internal.DefaultOfficeResourceViewer.createView(DefaultOfficeResourceViewer.java:457)
       at org.xwiki.rendering.internal.macro.office.OfficeMacro.execute(OfficeMacro.java:112)
       ... 15 more 

      I couldn't reproduce the problem on 14.2.0, there the office macro inside the async macro works as expected. This is caused by the changes in XWIKI-19684.

      Attachments

        Issue Links

          Activity

            People

              surli Simon Urli
              MichaelHamann Michael Hamann
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: