Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-23352

Paragraph text editor does not have any label

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • 17.5.0
    • Flamingo Skin
    • Unknown

    Description

      The content textarea in wiki edition mode is properly labelled with an item in the editMeta container.
      There is no such label when editing a paragraph of the content with the default edit mode being wiki.
      This UI can be found by clicking on the pen icons in view mode after setting up the right Admin config. This admin configuration is not the default XS, but it's the default one used in docker tests.


      It seems that in these conditions, the `editmeta.vm` template is not called while it should have been.

      https://github.com/xwiki/xwiki-platform/blob/53333ae70dfcd15564197f5ccc1f8c64efd96614/xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/edit.vm#L153-L160

      Note that there even is a skiplink targeting the `#editMeta` here, that doesn't work in this use case...

      This bug was first found by accessibility automatic tests. This is responsible for 7 failures of the `label` rule in flamingo-skin-docker WCAG tests.

      ```
      Validation in the test method [sectionSaveDoesNotOverwriteTheWholeContentWhenSyntax20]
      Check for [org.xwiki.test.ui.po.editor.WikiEditPage] at http://xwikiweb:8080/xwiki/bin/edit/NestedSectionEditIT/sectionSaveDoesNotOverwriteTheWholeContentWhenSyntax20/SectionEditing?editor=wiki&.
      Found [1] items

      1: Form elements must have labels
      Description: Ensure every form element has a label
      Help URL: https://dequeuniversity.com/rules/axe/4.10/label?application=axeAPI
      Help: Form elements must have labels
      Impact: critical
      Tags: cat.forms, wcag2a, wcag412, section508, section508.22.n, TTv5, TT5.c, EN-301-549, EN-9.4.1.2, ACT

      HTML element:
      <textarea data-syntax="xwiki/2.0" id="content" name="content" cols="80" rows="25" data-restricted="false">= Section7 =

      Content7</textarea>
      Selector: content
      Fix any of the following:
      Element does not have an implicit (wrapped) <label>
      Element does not have an explicit <label>
      aria-label attribute does not exist or is empty
      aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
      Element has no title attribute
      Element has no placeholder attribute
      Element's default semantics were not overridden with role="none" or role="presentation"
      ```

      Attachments

        Activity

          People

            Lucas C Charpentier Lucas
            Lucas C Charpentier Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: