Details
Description
Steps to reproduce
- Login as Admin
- Go to Administer Wiki > Editing > Edit Mode
- Set "Enable minor edits" to "No" and Save
- Go to a page (e.g. Sandbox)
- Click "Edit" button
- Make a change in the page content
- Click the drop-down arrow in the right of the 'Done' button
- Click "Summarize & Done"
- Observe the state of the "Minor change" checkbox
- Click on "Recent versions" button from the right side of the toolbar
- Observe the stat of the "Summarize changes" option
Expected results
Step 10: Since "Enable minor edits" from Administration is set to "No", the "Minor change" checkbox is not active (cannot be ticked).
Step 17: Also, the "Summarize changes" option from the "Recent versions" button on the right side of the toolbar is not active either, since it saves the changes as minor versions.
Actual results
The "Minor change" checkbox is active and so is the "Summarize changes" option from the "Recent versions" button on the right side of the toolbar.
If the "Minor change" checkbox is ticked and a brief description of the changes is inserted, then "Done" button is clicked, the page is not saved and the following error is displayed in JS console:
Uncaught (in promise) TypeError: can't access property "checked", this._oldToolbar.querySelector(...) is null _saveChangeSummary toolbar.js:204 _createChangeSummaryModal toolbar.js:137 jQuery 6 toolbar.js:204:52 _saveChangeSummary toolbar.js:204 _createChangeSummaryModal toolbar.js:137 jQuery 10 _createChangeSummaryModal toolbar.js:135 r toolbar.js:54 _createToolbar wysiwygEditor.js:192 _startRealtimeSync wysiwygEditor.js:118 n wysiwygEditor.js:82 d plugin.js:297 m plugin.js:311 execCb require.min.js:5 check require.min.js:5 enable require.min.js:5 bind require.min.js:5 emit require.min.js:5 each require.min.js:5 emit require.min.js:5 check require.min.js:5 enable require.min.js:5 bind require.min.js:5 emit require.min.js:5 each require.min.js:5 emit require.min.js:5 check require.min.js:5 enable require.min.js:5 bind require.min.js:5 emit require.min.js:5 each require.min.js:5 emit require.min.js:5 check require.min.js:5 enable require.min.js:5 init require.min.js:5 a require.min.js:5 completeLoad require.min.js:5 onScriptLoad require.min.js:5 (Async: EventListener.handleEvent) load require.min.js:5 load require.min.js:5 load require.min.js:5 fetch require.min.js:5 check require.min.js:5 enable require.min.js:5 enable require.min.js:5 enable require.min.js:5 bind require.min.js:5 each require.min.js:5 enable require.min.js:5 enable require.min.js:5 enable require.min.js:5 bind require.min.js:5 each require.min.js:5 enable require.min.js:5 enable require.min.js:5 enable require.min.js:5 bind require.min.js:5 each require.min.js:5 enable require.min.js:5 init require.min.js:5 s require.min.js:5 (Async: setTimeout handler) nextTick require.min.js:5 s require.min.js:5 requirejs require.min.js:5 d plugin.js:296 d plugin.js:295 InterpretGeneratorResume self-hosted:1332 AsyncFunctionNext self-hosted:800 (Async: async) init plugin.js:69 m plugin.js:311 execCb require.min.js:5 check require.min.js:5 enable require.min.js:5 bind require.min.js:5 emit require.min.js:5 each require.min.js:5 emit require.min.js:5 check require.min.js:5 enable require.min.js:5 bind require.min.js:5 emit require.min.js:5 each require.min.js:5 emit require.min.js:5 check require.min.js:5 enable require.min.js:5 init require.min.js:5 o require.min.js:5 bind require.min.js:5 load l10n.js:74 (Async: promise callback) load l10n.js:72 execCb require.min.js:5 check require.min.js:5 enable require.min.js:5 bind require.min.js:5 emit require.min.js:5 each require.min.js:5 emit require.min.js:5 check require.min.js:5
The same error is encountered if the "Summarize changes" option is clicked, a brief text is inserted and then the "Save" button is clicked.