Details
-
Improvement
-
Resolution: Unresolved
-
Major
-
None
-
17.10.14, 18.8.0
-
None
-
Unknown
-
Description
The Edit Macro dialog of the displayIcon and iconPicker macros shows rarely used parameters with the main ones, and the prefix field of iconPicker does not show the default the picker uses.
The macros to change, with the file where most of the fix is done:
- displayIcon: parameters declared in DisplayIconMacroParameters.java.
- iconPicker: parameters declared in its wiki macro definition, IconPickerMacro.xml.
KOs covered
| Macro | Criterion | Parameters | Problem |
|---|---|---|---|
| displayIcon | C8 advanced | iconSet | Taking an icon from another Icon Theme than the one of the wiki is rare, the XWiki pages that use the macro never set it outside the tests, but the field is not marked as advanced. |
| iconPicker | C8 advanced | class | No call of XWiki Standard sets class, only the sample on the page of the macro does, and it is not marked as advanced. |
| iconPicker | C3 defaults | prefix | The field opens empty and the description gives the default "image:icon:", but the JavaScript of the picker uses "icon:image:", so a user who relies on the description gets the opposite order. The most common example sets prefix="" and the next one prefix="icon:", neither is preselected. |
Impact found on macro fluidity
These 3 KOs come from the WYSIWYG usability audit of the macros, under the criteria C3 defaults, C8 advanced of its usability criteria. The page of each macro, linked in the table, has the full notes and the steps to reproduce. Fixing them means changing the parameter declarations of the macros: their groups, order, default values, mandatory and advanced flags.