Details
-
Improvement
-
Resolution: Unresolved
-
Major
-
None
-
17.10.14, 18.8.0
-
None
-
Unknown
-
Description
The script and velocity macros take an identifier chosen among the components installed on the wiki in a free text field, so the user has to know it and a wrong one is accepted or refused with a technical message.
The macros to change, with the file where most of the fix is done:
- script: DefaultScriptMacroParameters.java.
- velocity: VelocityMacroParameters.java.
The main problem:
- The values are components, script engines and Velocity filters, so the list has to be computed on the wiki rather than fixed in the macro.
Depends on
Most of these fields cannot be offered before these generic changes, each giving the macro the means to declare the expected value:
- XWIKI-23045, which lets a parameter get its values from a provider, with or without custom values.
KOs covered
| Macro | Criterion | Parameter | Problem | Depends on |
|---|---|---|---|---|
| script | C4 input-assistance | language | A free text field for an identifier chosen among the script engines installed on the wiki; a wrong value is refused with a message about the engine. | XWIKI-23045 |
| velocity | C4 input-assistance | filter | A free text field for one of the filters none, indent and html; a wrong value is accepted silently. | XWIKI-23045 |
Impact found on macro fluidity
These 2 KOs come from the WYSIWYG usability audit of the macros, under the criterion C4 input-assistance of its usability criteria. The page of each macro, linked in the table, has the full notes and the steps to reproduce. Fixing them means changing the declaration of the parameters in the macro definitions.
Attachments
Issue Links
- depends on
-
XWIKI-23045 Allow to define a provider of values for a macro parameter
-
- Open
-