Details
-
Improvement
-
Resolution: Unresolved
-
Major
-
None
-
17.10.14, 18.8.0
-
None
-
Unknown
-
Description
The gallery, tree and menu macros only use part of what their content can hold: images for the gallery, nested lists for the tree and the menu. The WYSIWYG editor lets the user put anything in their content, such as a table or a box, and shows it there, but the macros silently drop it or show it as is in view mode, with no message. The user only finds out after saving.
The macros to change, with the file where most of the fix is done:
- gallery: GalleryMacro.java.
- tree: Tree.xml.
- menu: MenuMacro.xml.
The main problems:
- The editor offers every editing feature inside the content, while only images or lists are used: unsupported content can be inserted or pasted with no notification.
- The unsupported content is shown in the editor but dropped or misplaced in view mode, so the editor and view mode disagree.
- The content description of the tree speaks of nested HTML unordered lists and links to the jstree documentation, while users type wiki lists in the WYSIWYG editor.
The improvement is to make the restriction visible, as the gallery and menu descriptions already state it: disable the unsupported features inside the content, notify the user when unsupported content is pasted, and, in view mode, report the content that is ignored instead of dropping it silently.
KOs covered
| Macro | Criterion | Problem |
|---|---|---|
| gallery | E3 nesting | A list, a table or a box in the content, like {{gallery}}* one{{/gallery}}, is shown in the editor but silently dropped in view mode, which shows an empty "0 / 0" slide-show. |
| tree | E3 nesting | A table or a box in the content, like {{tree}}{{box}}Text{{/box}}{{/tree}}, is shown in the editor but silently dropped in view mode, and a box in a list item of the content leaves only the item text. |
| menu | E3 nesting | A table or a box in the content renders with no error but is shown as is inside the menu bar, and nothing in the editor says that the content expects a list. |
Impact found on macro fluidity
These 3 KOs come from the WYSIWYG usability audit of the macros, under the criterion E3 nesting of its usability criteria, which asks that when the macro content accepts less than the rest of the page, the restriction is visible. The page of each macro, linked in the table, has the full notes and the steps to reproduce. The other part of the E3 KOs of gallery, tree and menu, their error in a list item or a table cell, is XWIKI-23501.
Attachments
Issue Links
- is related to
-
XWIKI-23501 Block macros are broken in tables and lists
-
- Open
-