Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-25758

Use CSS variables instead of color theme Velocity variables in the stylesheets that reference skin files

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Major
    • None
    • 17.10.15
    • None
    • Unknown

    Description

      Part of the removal of the color theme Velocity variables ($theme, loaded with colorThemeInit.vm) from the stylesheets of XWiki Standard, following XWIKI-25649. The CSS variables introduced by XWIKI-22667 expose the same colors.

      Some stylesheets use color theme Velocity variables next to other Velocity code, mostly $xwiki.getSkinFile(...) calls for icon URLs, 113 usages in total:

      • In the WAR: js/xwiki/editors/dataeditors.css, js/xwiki/importer/import.css, uicomponents/extension/extension.css, uicomponents/logging/logging.css, uicomponents/suggest/suggest.css and js/xwiki/viewers/attachments.css
      • In the search webjar: search.css
      • In wiki pages: the first stylesheet of AppWithinMinutes.ClassEditSheet, AnnotationCode.Style, AnnotationCode.Settings, XWiki.SearchSuggestConfigSheet, Main.Tags, XWiki.AttachmentSelector, XWiki.XWikiUserProfileSheet, WikiManager.WikisMacro and the first stylesheet of WikiManager.CreateWiki

      We should:

      • Replace each color theme Velocity variable of these stylesheets with its CSS variable.
      • Remove the loading of colorThemeInit.vm from them.

      These stylesheets keep their Velocity evaluation, since the rest of their Velocity code stays.

      The replacement follows the mapping Flamingo already uses in colorThemeMappingOutput.vm, for instance borderColor becomes -xwiki-border-color, textSecondaryColor becomes text-muted and highlightColor becomes -nav-link-hover-bg.

      Visible change: none expected beyond small color differences. backgroundSecondaryColor becomes -xwiki-background-secondary-color, which follows the color theme, and a few CSS variables such as -text-muted have a value adjusted for contrast.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Lucas C Charpentier Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: