Details
-
Improvement
-
Resolution: Unresolved
-
Major
-
None
-
17.10.15
-
None
-
Unknown
-
Description
Part of the removal of the color theme Velocity variables ($theme, loaded with colorThemeInit.vm) from the stylesheets of XWiki Standard, following XWIKI-25649. The CSS variables introduced by XWIKI-22667 expose the same colors.
js/xwiki/table/livetable.css holds 50 usages of the color theme Velocity variables, the highest count of any stylesheet.
We should:
- Replace each color theme Velocity variable of this stylesheet with its CSS variable.
- Remove the loading of colorThemeInit.vm from it.
The stylesheet keeps its Velocity evaluation, since it also uses $xwiki.getSkinFile(...) for its icons.
The replacement follows the mapping Flamingo already uses in colorThemeMappingOutput.vm, for instance borderColor becomes -xwiki-border-color, textSecondaryColor becomes text-muted and highlightColor becomes -nav-link-hover-bg.
Visible change: none expected beyond small color differences. backgroundSecondaryColor becomes -xwiki-background-secondary-color, which follows the color theme, and a few CSS variables such as -text-muted have a value adjusted for contrast.
Attachments
Issue Links
- relates to
-
XWIKI-25649 Use CSS variables instead of color theme Velocity variables in the Solr search stylesheet
-
- Closed
-