Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-25763

Remove the use of the color theme Velocity variables from the Invitation application

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Major
    • None
    • 17.10.15
    • Invitation
    • None
    • Unknown

    Description

      Part of the removal of the color theme Velocity variables ($theme, loaded with colorThemeInit.vm) from the stylesheets of XWiki Standard, following XWIKI-25649. The CSS variables introduced by XWIKI-22667 expose the same colors.

      The Invitation application loads colorThemeInit.vm in three places to read colors from the $theme Velocity variable:

      • The mail body templates of Invitation.InvitationCommon and Invitation.InvitationConfig, for the color of the links (linkColor) and of the decline link (notificationErrorColor). Both already define fallback values, #4791BC and #ca302c, for when $theme is empty.
      • The stylesheet of Invitation.InvitationCommon, for a border (menuSelectedEntryBackgroundColor) and a background (pageContentBackgroundColor).

      We should remove every use of $theme and of colorThemeInit.vm from the application:

      • In the mail templates, use the two fallback colors directly. A mail client cannot resolve CSS variables, so fixed colors are the only option there.
      • In the stylesheet, use the CSS variables -navbar-default-link-active-bg and -xwiki-page-content-bg, and disable its Velocity parsing.

      Visible change: the links of the invitation mails no longer follow the color theme of the wiki, they always use the two fixed colors.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Lucas C Charpentier Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: