Details
-
Improvement
-
Resolution: Unresolved
-
Major
-
None
-
5.4-rc-1
-
None
-
Unknown
-
Description
The edit shortcuts, which are made of a single letter, are enabled in all modes, edit mode included ('o' for object editor, 'r' for rights and so on).
The fact that these extensions are working when the user is already in edit mode is, at the same time
1/ slightly useless. In general once you're in the edit mode you're no longer in a hurry to get into edit mode
2/ VERY dangerous. Since edit mode is essentially about typing stuff, with all the letters of the alphabet in general, it's enough that an input loses focus somehow while you type, or that you type by mistake without focusing an editable area before and your whole page is reloaded in another edit mode. In edit mode, hitting keys is the rule so it cannot be a shortcut for something, it's the shortcut for actually typing what you need to type.
Scenario:
1/ create a new page, edit in wysiwyg
2/ type some text
3/ open a link dialog, to add a Wiki link. Go to "search", search something, click on a result in that list (thus removing the focus from the search text input). hit the 'o' key: all page will be reloaded in edit object mode. Hitting "back" to go to the wysiwyg editor to recover what you were doing before should work, but it might fail for some reasons (browser, etc). If it does, all the work is lost.
Attachments
Issue Links
- is related to
-
XWIKI-4516 Create a preference to enable/disable keyboard shortcuts
- Open
-
XWIKI-21215 Disable edit button in edit mode
- Open
-
XWIKI-6927 When leaving the edit mode without saving, notify the user that there are changes he needs to save
- Reopened
- relates to
-
XWIKI-3832 Add a help button on the tool bar
- Open
-
XWIKI-14412 Add ability to hint the shortcuts where they apply
- Open
-
XWIKI-12186 When editing, the "edit" button should become a "save" button which does "save and view"
- Open