Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-14309

Don't display the 'Viewers' menu category when the #docextra are hidden

Details

    • Unknown
    • N/A
    • N/A

    Description

      • Go to Help.Videos.WebHome
      • Check the content menu, see before.png

      See expected.png

      Attachments

        1. before1.png
          before1.png
          1.10 MB
        2. before2.png
          before2.png
          1.13 MB
        3. expected.png
          expected.png
          53 kB

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-14716 Viewers section should be hidden if there are no viewers to display

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-12993 Don't display the content menu divider when there are no viewers

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-14073 Hide the Copy action when the wiki is in readonly mode

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-14265 Improve usability for the content menu

          • Major - Major loss of function.
          • Closed
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-13799 Hiding docextra from layout also removes the menu entries, blocking navigation to viewers

          • Major - Major loss of function.
          • Closed

          Activity

            [XWIKI-14309] Don't display the 'Viewers' menu category when the #docextra are hidden
            vmassol Vincent Massol added a comment -

            FTR I've updated the following docs:

            http://www.xwiki.org/xwiki/bin/view/Documentation/AdminGuide/Configuration/#HControllingPageTabs
            http://www.xwiki.org/xwiki/bin/view/Documentation/DevGuide/Scripting/#HControllingPageTabs
            http://extensions.xwiki.org/xwiki/bin/view/Extension/Administration%20Application#HPresentation
            http://www.xwiki.org/xwiki/bin/view/FAQ/How%20to%20control%20order%20of%20tabs%20at%20bottom%20of%20pages
            http://www.xwiki.org/xwiki/bin/view/Documentation/DevGuide/Scripting/#HControlContentFooter

            vmassol Vincent Massol added a comment - FTR I've updated the following docs: http://www.xwiki.org/xwiki/bin/view/Documentation/AdminGuide/Configuration/#HControllingPageTabs http://www.xwiki.org/xwiki/bin/view/Documentation/DevGuide/Scripting/#HControllingPageTabs http://extensions.xwiki.org/xwiki/bin/view/Extension/Administration%20Application#HPresentation http://www.xwiki.org/xwiki/bin/view/FAQ/How%20to%20control%20order%20of%20tabs%20at%20bottom%20of%20pages http://www.xwiki.org/xwiki/bin/view/Documentation/DevGuide/Scripting/#HControlContentFooter
            vmassol Vincent Massol added a comment -

            Alternatives:

            • Computes the array first before the call to shortcuts.vm. This means breaking shortcuts.vm into 2 vms.
            • Duplicate the conditions into menus_content.vm but that wouldn't be very nice
            • Extend the data format for displaying entries by adding the concept of titles. Possibly the best solution even if a bit more complex than moving the call to submenuheader to shortcuts.vm
            vmassol Vincent Massol added a comment - Alternatives: Computes the array first before the call to shortcuts.vm. This means breaking shortcuts.vm into 2 vms. Duplicate the conditions into menus_content.vm but that wouldn't be very nice Extend the data format for displaying entries by adding the concept of titles. Possibly the best solution even if a bit more complex than moving the call to submenuheader to shortcuts.vm
            vmassol Vincent Massol added a comment -

            The easiest is probably to move the call to 

            #submenuheader('core.menu.actions.viewers')

            into shortcuts.vm.

            enygma WDYT?

            vmassol Vincent Massol added a comment - The easiest is probably to move the call to #submenuheader('core.menu.actions.viewers') into shortcuts.vm. enygma WDYT?
            vmassol Vincent Massol added a comment -

            The bug is at https://github.com/xwiki/xwiki-platform/blob/7f2d1c8af7674fcf4611ae55a85639c9f214fdf5/xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/menus_content.vm#L361 which doesn't check if there are entries

            Regression caused by https://github.com/xwiki/xwiki-platform/commit/34e6e8b08f7a7b60665bf11265518b528a0a58e8#diff-b597aff071a5943644b04eebcac8b44dR357 AFAICS

            Regression introduced in XWIKI-14265

            vmassol Vincent Massol added a comment - The bug is at https://github.com/xwiki/xwiki-platform/blob/7f2d1c8af7674fcf4611ae55a85639c9f214fdf5/xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/menus_content.vm#L361 which doesn't check if there are entries Regression caused by https://github.com/xwiki/xwiki-platform/commit/34e6e8b08f7a7b60665bf11265518b528a0a58e8#diff-b597aff071a5943644b04eebcac8b44dR357 AFAICS Regression introduced in XWIKI-14265

            People

              enygma Eduard Moraru
              evalica Ecaterina Moraru (Valica)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: