Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-17187

spinner.gif coming from a webjar resource has an absolute URL when the descriptor is different from the initial request

    XMLWordPrintable

Details

    • Unit
    • Unknown
    • N/A
    • N/A

    Description

      To reproduce:

      tree.min.css contains the following at runtime:

      .jstree-ocl{background-image:url("http://localhost/xwiki/resources/icons/xwiki/spinner.gif?cache-version=1585234810000"); in tree.min.css

      When https://github.com/xwiki/xwiki-platform/blob/2359341cb50df1fc2df2d981ffad01b98a20f05a/xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiServletURLFactory.java#L806 is called we have:

      The issue is that the original URL for the webjar thread is not empty (it contains http://localhost:8080), and since our default main wiki descriptor doesn't have the port set, it generates a URL with http://localhost/. Thus "!surl.startsWith(this.originalURL.toString()" is true.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-16497 Webjar resource handler use a background thread XWikiContext instead of one generated from the input request

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-16496 XWikiServletURLFactory#getURL may return an absolute URL instead of the expected relative one in a background thread

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-16759 Use the main wiki descriptor server field for the domain name even in path based mode

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-16160 Spinner.gif requested with an absolute URL instead of a relative one

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            People

              tmortagne Thomas Mortagne
              vmassol Vincent Massol
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: