Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-17210

Notifications related errors with broken UI when upgrading from XWiki 8.4.5 to 11.10.x and 12.2.1 by keeping configuration files

    XMLWordPrintable

Details

    • Bug
    • Resolution: Invalid
    • Critical
    • None
    • 11.10.3, 12.2.1
    • Notifications
    • Docker for Windows, XWiki 11.10.3, 11.10..4, 12.2.1, Edge 80 browser (on Windows 10)
    • Unknown

    Description

      STEPS TO REPRODUCE

      1. Create an older instance of XWiki 8.4.5 in Docker (I tested with 8.4.5 on both MySQL and PostgreSQL)
      2. Close the instance (Stop the XWiki running container)
      3. Start the new XWiki version (e.g. 11.10.3, 11.10.4 or 12.2.1)
      4. Follow the Distribution Wizard through the upgrade process

      EXPECTED RESULTS

      The upgrade process is completed successfully without errors.

      ACTUAL RESULTS

      After the very last step, when entering the upgraded instance, there are encountered some errors related to notifications and the page UI is broken.

      Stacktrace from upgrade from 8.4.5 to 11.10.4

      2020-04-13 10:43:18,318 [http://localhost:8450/bin/view/Main/] ERROR o.x.v.i.DefaultVelocityEngine  - Exception in macro #displayCheckedIfWatched called at 58:xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 3, column 44]
      2020-04-13 10:43:18,318 [http://localhost:8450/bin/view/Main/] ERROR o.x.v.i.DefaultVelocityEngine  - Exception in macro #generateNotificationInput called at 58:xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 42, column 1]
      2020-04-13 10:43:20,580 [http://localhost:8450/bin/bin/jsx/Panels/Applications?&docVersion=3.1&_=1586774600281] ERROR o.x.v.i.DefaultVelocityEngine  - Exception in macro #displayCheckedIfWatched called at 63:xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 3, column 44]
      2020-04-13 10:43:20,580 [http://localhost:8450/bin/bin/jsx/Panels/Applications?&docVersion=3.1&_=1586774600281] ERROR o.x.v.i.DefaultVelocityEngine  - Exception in macro #generateNotificationInput called at 63:xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 42, column 1]
      2020-04-13 10:43:20,684 [http://localhost:8450/bin/bin/ssx/IconThemes/FontAwesome?&docVersion=2.1] ERROR o.x.v.i.DefaultVelocityEngine  - Exception in macro #displayCheckedIfWatched called at 56:xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 3, column 44]
      2020-04-13 10:43:20,684 [http://localhost:8450/bin/bin/ssx/IconThemes/FontAwesome?&docVersion=2.1] ERROR o.x.v.i.DefaultVelocityEngine  - Exception in macro #generateNotificationInput called at 56:xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 42, column 1]
      2020-04-13 10:43:20,748 [http://localhost:8450/bin/bin/ssx/Help/SupportPanel/WebHome?&docVersion=3.1] ERROR o.x.v.i.DefaultVelocityEngine  - Exception in macro #displayCheckedIfWatched called at 58:xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 3, column 44]
      2020-04-13 10:43:20,749 [http://localhost:8450/bin/bin/ssx/Help/SupportPanel/WebHome?&docVersion=3.1] ERROR o.x.v.i.DefaultVelocityEngine  - Exception in macro #generateNotificationInput called at 58:xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 42, column 1]
      2020-04-13 10:43:20,769 [http://localhost:8450/bin/bin/ssx/Panels/Applications?&docVersion=3.1] ERROR o.x.v.i.DefaultVelocityEngine  - Exception in macro #displayCheckedIfWatched called at 62:xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 3, column 44]
      2020-04-13 10:43:20,769 [http://localhost:8450/bin/bin/ssx/Panels/Applications?&docVersion=3.1] ERROR o.x.v.i.DefaultVelocityEngine  - Exception in macro #generateNotificationInput called at 62:xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 42, column 1]
      2020-04-13 10:43:22,931 [http://localhost:8450/bin/bin/jsx/IconThemes/FontAwesome?&docVersion=2.1&_=1586774600282] ERROR o.x.v.i.DefaultVelocityEngine  - Exception in macro #displayCheckedIfWatched called at 64:xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 3, column 44]
      2020-04-13 10:43:22,931 [http://localhost:8450/bin/bin/jsx/IconThemes/FontAwesome?&docVersion=2.1&_=1586774600282] ERROR o.x.v.i.DefaultVelocityEngine  - Exception in macro #generateNotificationInput called at 64:xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 42, column 1]
      2020-04-13 10:43:23,809 [Notification event executor: count : 4true/16xwiki:XWiki.ILIE///////21//////5xwiki/true : 1] ERROR .r.i.NotificationEventExecutor - Failed to retrieve notifications for cache key [4true/16xwiki:XWiki.ILIE///////21//////5xwiki/true]
      org.xwiki.notifications.NotificationException: Error while loading the notification filter preferences of the user [xwiki:XWiki.ILIE].
              at org.xwiki.notifications.filters.internal.NotificationFilterPreferenceStore.getPreferencesOfUser(NotificationFilterPreferenceStore.java:127)
              at org.xwiki.notifications.filters.internal.DefaultModelBridge.getInternalFilterPreferences(DefaultModelBridge.java:93)
              at org.xwiki.notifications.filters.internal.DefaultModelBridge.getFilterPreferences(DefaultModelBridge.java:100)
              at org.xwiki.notifications.filters.internal.CachedModelBridge.getFilterPreferences(CachedModelBridge.java:113)
              at org.xwiki.notifications.filters.internal.UserProfileNotificationFilterPreferenceProvider.getFilterPreferences(UserProfileNotificationFilterPreferenceProvider.java:59)
              at org.xwiki.notifications.filters.internal.DefaultNotificationFilterPreferenceManager.getFilterPreferences(DefaultNotificationFilterPreferenceManager.java:75)
              at org.xwiki.notifications.rest.internal.DefaultNotificationsResource.useUserPreferences(DefaultNotificationsResource.java:384)
              at org.xwiki.notifications.rest.internal.DefaultNotificationsResource.getCompositeEvents(DefaultNotificationsResource.java:339)
              at org.xwiki.notifications.rest.internal.DefaultNotificationsResource.lambda$getCompositeEvents$0(DefaultNotificationsResource.java:190)
              at org.xwiki.notifications.rest.internal.NotificationEventExecutor$CallableEntry.execute(NotificationEventExecutor.java:202)
              at org.xwiki.notifications.rest.internal.NotificationEventExecutor$CallableEntry.call(NotificationEventExecutor.java:163)
              at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
              at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
              at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
              at java.base/java.lang.Thread.run(Thread.java:834)
      Caused by: org.xwiki.query.QueryException: Exception while executing query. Query statement = [select nfp from DefaultNotificationFilterPreference nfp where nfp.owner = :owner order by nfp.id]
              at com.xpn.xwiki.store.hibernate.query.HqlQueryExecutor.execute(HqlQueryExecutor.java:182)
              at org.xwiki.query.internal.DefaultQueryExecutorManager.execute(DefaultQueryExecutorManager.java:72)
              at org.xwiki.query.internal.DefaultQuery.execute(DefaultQuery.java:306)
              at org.xwiki.notifications.filters.internal.NotificationFilterPreferenceStore.getPreferencesOfUser(NotificationFilterPreferenceStore.java:119)
              ... 14 common frames omitted
      Caused by: com.xpn.xwiki.XWikiException: Error number 0 in 3: Exception while hibernate execute
              at com.xpn.xwiki.store.XWikiHibernateBaseStore.execute(XWikiHibernateBaseStore.java:826)
              at com.xpn.xwiki.store.XWikiHibernateBaseStore.executeRead(XWikiHibernateBaseStore.java:889)
              at com.xpn.xwiki.store.hibernate.query.HqlQueryExecutor.execute(HqlQueryExecutor.java:170)
              ... 17 common frames omitted
      Caused by: java.lang.IllegalArgumentException: org.hibernate.hql.internal.ast.QuerySyntaxException: DefaultNotificationFilterPreference is not mapped [select nfp from DefaultNotificationFilterPreference nfp where nfp.owner = :owner order by nfp.id]
              at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:138)
              at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:181)
              at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:188)
              at org.hibernate.internal.AbstractSharedSessionContract.createQuery(AbstractSharedSessionContract.java:718)
              at org.hibernate.engine.spi.SessionDelegatorBaseImpl.createQuery(SessionDelegatorBaseImpl.java:576)
              at com.xpn.xwiki.internal.store.hibernate.legacy.LegacySessionImplementor.createQuery(LegacySessionImplementor.java:119)
              at com.xpn.xwiki.internal.store.hibernate.legacy.LegacySessionImplementor.createQuery(LegacySessionImplementor.java:47)
              at com.xpn.xwiki.store.hibernate.query.HqlQueryExecutor.createHibernateQuery(HqlQueryExecutor.java:207)
              at com.xpn.xwiki.store.hibernate.query.HqlQueryExecutor.lambda$execute$0(HqlQueryExecutor.java:171)
              at com.xpn.xwiki.store.XWikiHibernateBaseStore.execute(XWikiHibernateBaseStore.java:820)
              ... 19 common frames omitted
      Caused by: org.hibernate.hql.internal.ast.QuerySyntaxException: DefaultNotificationFilterPreference is not mapped [select nfp from DefaultNotificationFilterPreference nfp where nfp.owner = :owner order by nfp.id]
              at org.hibernate.hql.internal.ast.QuerySyntaxException.generateQueryException(QuerySyntaxException.java:79)
              at org.hibernate.QueryException.wrapWithQueryString(QueryException.java:103)
              at org.hibernate.hql.internal.ast.QueryTranslatorImpl.doCompile(QueryTranslatorImpl.java:220)
              at org.hibernate.hql.internal.ast.QueryTranslatorImpl.compile(QueryTranslatorImpl.java:144)
              at org.hibernate.engine.query.spi.HQLQueryPlan.<init>(HQLQueryPlan.java:113)
              at org.hibernate.engine.query.spi.HQLQueryPlan.<init>(HQLQueryPlan.java:73)
              at org.hibernate.engine.query.spi.QueryPlanCache.getHQLQueryPlan(QueryPlanCache.java:155)
              at org.hibernate.internal.AbstractSharedSessionContract.getQueryPlan(AbstractSharedSessionContract.java:600)
              at org.hibernate.internal.AbstractSharedSessionContract.createQuery(AbstractSharedSessionContract.java:709)
              ... 25 common frames omitted
      Caused by: org.hibernate.hql.internal.ast.QuerySyntaxException: DefaultNotificationFilterPreference is not mapped
              at org.hibernate.hql.internal.ast.util.SessionFactoryHelper.requireClassPersister(SessionFactoryHelper.java:169)
              at org.hibernate.hql.internal.ast.tree.FromElementFactory.addFromElement(FromElementFactory.java:91)
              at org.hibernate.hql.internal.ast.tree.FromClause.addFromElement(FromClause.java:79)
              at org.hibernate.hql.internal.ast.HqlSqlWalker.createFromElement(HqlSqlWalker.java:331)
              at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.fromElement(HqlSqlBaseWalker.java:3695)
              at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.fromElementList(HqlSqlBaseWalker.java:3584)
              at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.fromClause(HqlSqlBaseWalker.java:720)
              at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.query(HqlSqlBaseWalker.java:576)
              at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.selectStatement(HqlSqlBaseWalker.java:313)
              at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.statement(HqlSqlBaseWalker.java:261)
              at org.hibernate.hql.internal.ast.QueryTranslatorImpl.analyze(QueryTranslatorImpl.java:272)
              at org.hibernate.hql.internal.ast.QueryTranslatorImpl.doCompile(QueryTranslatorImpl.java:192)
              ... 31 common frames omitted

      Stacktrace from upgrade from 8.4.5 to 12.2.1:

      2020-04-14 09:36:14,866 [http://localhost:8450/bin/view/Main/] ERROR o.a.v.d.null                   - Exception in macro #displayCheckedIfWatched called at xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 3, column 44]
      2020-04-14 09:36:14,866 [http://localhost:8450/bin/view/Main/] ERROR o.a.v.d.null                   - Exception in macro #generateNotificationInput called at xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 42, column 1]
      2020-04-14 09:36:16,756 [http://localhost:8450/bin/bin/ssx/IconThemes/FontAwesome?&docVersion=2.1] ERROR o.a.v.d.null                   - Exception in macro #displayCheckedIfWatched called at xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 3, column 44]
      2020-04-14 09:36:16,757 [http://localhost:8450/bin/bin/ssx/IconThemes/FontAwesome?&docVersion=2.1] ERROR o.a.v.d.null                   - Exception in macro #generateNotificationInput called at xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 42, column 1]
      2020-04-14 09:36:16,852 [http://localhost:8450/bin/bin/ssx/Help/SupportPanel/WebHome?&docVersion=3.1] ERROR o.a.v.d.null                   - Exception in macro #displayCheckedIfWatched called at xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 3, column 44]
      2020-04-14 09:36:16,852 [http://localhost:8450/bin/bin/ssx/Help/SupportPanel/WebHome?&docVersion=3.1] ERROR o.a.v.d.null                   - Exception in macro #generateNotificationInput called at xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 42, column 1]
      2020-04-14 09:36:16,882 [http://localhost:8450/bin/bin/ssx/Panels/Applications?&docVersion=3.1] ERROR o.a.v.d.null                   - Exception in macro #displayCheckedIfWatched called at xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 3, column 44]
      2020-04-14 09:36:16,882 [http://localhost:8450/bin/bin/ssx/Panels/Applications?&docVersion=3.1] ERROR o.a.v.d.null                   - Exception in macro #generateNotificationInput called at xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 42, column 1]
      2020-04-14 09:36:16,949 [http://localhost:8450/bin/bin/jsx/Panels/Applications?&docVersion=3.1&_=1586856976414] ERROR o.a.v.d.null                   - Exception in macro #displayCheckedIfWatched called at xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 3, column 44]
      2020-04-14 09:36:16,949 [http://localhost:8450/bin/bin/jsx/Panels/Applications?&docVersion=3.1&_=1586856976414] ERROR o.a.v.d.null                   - Exception in macro #generateNotificationInput called at xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 42, column 1]
      2020-04-14 09:36:19,051 [http://localhost:8450/bin/bin/jsx/IconThemes/FontAwesome?&docVersion=2.1&_=1586856976415] ERROR o.a.v.d.null                   - Exception in macro #displayCheckedIfWatched called at xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 3, column 44]
      2020-04-14 09:36:19,051 [http://localhost:8450/bin/bin/jsx/IconThemes/FontAwesome?&docVersion=2.1&_=1586856976415] ERROR o.a.v.d.null                   - Exception in macro #generateNotificationInput called at xwiki:XWiki.Notifications.Code.NotificationsDisplayerUIX^XWiki.UIExtensionClass[0][line 42, column 1]

      I also tested by upgrading from XWiki 10.11.11 to both 11.10.4 and 12.2.1 on Docker, but I didn't manage to reproduce the issue.

      The issue does also reproduce on my local machine environment (Windows 10, Tomcat 9.0.31), if the config files (hibernate.cfg.xml, xwiki.cfg and xwiki.properties) from 8.4.5 are copied to the new WAR before running the upgrade.

      Attachments

        Issue Links

          Activity

            People

              surli Simon Urli
              iandriuta Ilie Andriuta
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: