Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-20842

More actions button is an anchor

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 15.5-rc-1
    • 15.2
    • Menu
    • Unknown
    • N/A
    • N/A
    • Pull Request accepted
    • 1.3.1 Info and Relationships

    Description

      The region to drop down more actions has a link nature instead of a button.
      Quick definitions:

      Links take the user somewhere, buttons do things

      More formal definitions, from mdn web docs:

      The <a> HTML element (or anchor element), with its href attribute, creates a hyperlink to web pages, files, email addresses, locations in the same page, or anything else a URL can address.


      The <button> HTML element is an interactive element activated by a user with a mouse, keyboard, finger, voice command, or other assistive technology. Once activated, it then performs an action, such as submitting a form or opening a dialog.

      Here, we want to open a dialog, so we should use a button.
      This change is important for screen readers: they won't read the region the same way depending on its nature.

      Attachments

        Issue Links

          Activity

            People

              Lucas C Charpentier Lucas
              Lucas C Charpentier Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: