Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-22893

Improve consistency of global LESS variable declaration in Flamingo

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • 17.1.0-rc-1
    • Flamingo Skin
    • Unknown

    Description

      All the XWiki specific variables should be defined in variables.less . Other LESS files should only contain styles in themselves.

      In addition, the variable `@loginFormMaxWidth` should be renamed because it did not respect our naming convention (strictly speaking we don't have one for naming LESS variables, but we have one for HTML/CSS classes and bootstrap had one that we followed for pretty much all other variables). This is technically a backward compatibility break, but the name and use of this variable is so niche that I doubt anyone used it in a customization...

      Attachments

        Activity

          People

            Unassigned Unassigned
            Lucas C Charpentier Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: