Details
-
Improvement
-
Resolution: Unresolved
-
Major
-
None
-
17.10.14, 18.8.0
-
None
-
Unknown
-
Description
The container and menu macros take a value from a short list in a free text field of the Edit Macro dialog, so a typo or another case is accepted and gives no layout or a plain list.
The macros to change, with the file where most of the fix is done:
- container: ContainerMacroParameters.java.
- menu: MenuMacro.xml.
The main problems:
- The layouts of container are components, only columns in XWiki Standard, so their list has to be computed on the wiki.
- The menu type combines a type, horizontal or vertical, with modifiers, which a wiki macro cannot declare as a list.
Depends on
Most of these fields cannot be offered before these generic changes, each giving the macro the means to declare the expected value:
- XWIKI-23045, which lets a parameter get its values from a provider, with or without custom values.
KOs covered
| Macro | Criterion | Parameter | Problem | Depends on |
|---|---|---|---|---|
| container | C4 input-assistance | layoutStyle | A free text field for one of the installed layouts, only columns in XWiki Standard: Columns is accepted and gives no layout. | XWIKI-23045 |
| menu | C4 input-assistance | type | A free text field for horizontal or vertical plus the modifiers fixedWidth, collapsible and open, where a select and checkboxes could be used: Horizontal is accepted and gives a plain list. | XWIKI-23045 |
Impact found on macro fluidity
These 2 KOs come from the WYSIWYG usability audit of the macros, under the criterion C4 input-assistance of its usability criteria. The page of each macro, linked in the table, has the full notes and the steps to reproduce. Fixing them means changing the declaration of the parameters in the macro definitions.
Attachments
Issue Links
- depends on
-
XWIKI-23045 Allow to define a provider of values for a macro parameter
-
- Open
-