Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-25757

Use CSS variables instead of color theme Velocity variables in the wiki page stylesheets that need no other Velocity code

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Major
    • None
    • 17.10.15
    • Flamingo Skin
    • None
    • Unknown

    Description

      Part of the removal of the color theme Velocity variables ($theme, loaded with colorThemeInit.vm) from the stylesheets of XWiki Standard, following XWIKI-25649. The CSS variables introduced by XWIKI-22667 expose the same colors.

      25 StyleSheetExtension objects of the wiki pages of XWiki Standard are parsed with Velocity only to load colorThemeInit.vm and read color theme variables, 80 usages in total:

      • AppWithinMinutes.LiveTableEditSheet, AppWithinMinutes.CreateApplication, AppWithinMinutes.StaticList and the second stylesheet of AppWithinMinutes.ClassEditSheet
      • Panels.PanelWizard and Panels.Applications
      • XWiki.AdminSheet and XWiki.TemplateProviderMacros
      • IconThemesCode.IconPicker
      • FlamingoThemesCode.ThemeSheet and FlamingoThemesCode.WebHomeSheet
      • SkinsCode.XWikiSkinsSheet
      • XWiki.SharePage
      • WikiManager.UserWikiSheet and the second stylesheet of WikiManager.CreateWiki
      • ExtensionCode.ExtensionSheet, ExtensionCode.ExtensionVersionSheet and ExtensionCode.ProjectVersionSheet
      • XWiki.Extension.Security.Code.NotificationAlert
      • XWiki.Notifications.Code.NotificationsDisplayerUIX
      • Image.Style.Code.DefaultImageStyleStyleSheet
      • Main.SolrMediaTypeFacet, Main.SolrSpaceFacet and XWiki.SolrSearchAdmin
      • Main.MessageSenderMacro

      We should:

      • Replace each color theme Velocity variable of these stylesheets with its CSS variable.
      • Remove the loading of colorThemeInit.vm from them.
      • Disable the Velocity parsing of these stylesheets.

      The replacement follows the mapping Flamingo already uses in colorThemeMappingOutput.vm, for instance borderColor becomes -xwiki-border-color, textSecondaryColor becomes text-muted and highlightColor becomes -nav-link-hover-bg.

      Visible change: none expected beyond small color differences. backgroundSecondaryColor becomes -xwiki-background-secondary-color, which follows the color theme, and a few CSS variables such as -text-muted have a value adjusted for contrast.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Lucas C Charpentier Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: