Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-8711

Failure to update the schema during migration doesn't fail the migration

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.4
    • Fix Version/s: 4.4.1
    • Component/s: Storage
    • Labels:
      None
    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Similar issues:

      Description

      Namely, XWikiBaseStore#updateSchema does not throw on error

      Example:

      2013-01-18 11:30:59,872 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  .HibernateDataMigrationManager - Starting migration for database  [playground]... 
      2013-01-18 11:30:59,878 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  .HibernateDataMigrationManager - Current storage version = [42000] 
      2013-01-18 11:30:59,878 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  .HibernateDataMigrationManager - List of migrations that will be executed: 
      2013-01-18 11:30:59,878 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  .HibernateDataMigrationManager -   R43000XWIKI6691 - Reduce the size of the ASE_REQUESTID column to 48-chars 
      2013-01-18 11:30:59,878 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  .HibernateDataMigrationManager - Updating database schema: 
      2013-01-18 11:30:59,878 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  .HibernateDataMigrationManager - [schema] - Running pre-hibernate liquibase change logs 
      2013-01-18 11:31:01,226 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  c.x.x.s.m.liquibase            - Successfully acquired change log lock 
      2013-01-18 11:31:01,485 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  c.x.x.s.m.liquibase            - Reading from `DATABASECHANGELOG` 
      2013-01-18 11:31:01,499 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  c.x.x.s.m.liquibase            - Reading from `DATABASECHANGELOG` 
      2013-01-18 11:31:01,516 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  c.x.x.s.m.liquibase            - Successfully released change log lock 
      2013-01-18 11:31:01,517 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  .HibernateDataMigrationManager - [schema] - Running hibernate updates 
      2013-01-18 11:31:02,117 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] ERROR .x.x.s.XWikiHibernateBaseStore - Failed updating schema while executing query [create index EVENT_REQUESTID on activitystream_events (ase_requestid)] 
      com.mysql.jdbc.exceptions.MySQLSyntaxErrorException: BLOB/TEXT column 'ase_requestid' used in key specification without a key length
      	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:936) ~[mysql-connector-java-5.0.7.jar:na]
      	at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:2985) ~[mysql-connector-java-5.0.7.jar:na]
      	at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:1631) ~[mysql-connector-java-5.0.7.jar:na]
      	at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:1723) ~[mysql-connector-java-5.0.7.jar:na]
      	at com.mysql.jdbc.Connection.execSQL(Connection.java:3250) ~[mysql-connector-java-5.0.7.jar:na]
      	at com.mysql.jdbc.Statement.executeUpdate(Statement.java:1355) ~[mysql-connector-java-5.0.7.jar:na]
      	at com.mysql.jdbc.Statement.executeUpdate(Statement.java:1270) ~[mysql-connector-java-5.0.7.jar:na]
      	at org.apache.commons.dbcp.DelegatingStatement.executeUpdate(DelegatingStatement.java:228) ~[commons-dbcp-1.3.jar:1.3]
      	at org.apache.commons.dbcp.DelegatingStatement.executeUpdate(DelegatingStatement.java:228) ~[commons-dbcp-1.3.jar:1.3]
      	at org.apache.commons.dbcp.DelegatingStatement.executeUpdate(DelegatingStatement.java:228) ~[commons-dbcp-1.3.jar:1.3]
      	at com.xpn.xwiki.store.XWikiHibernateBaseStore.updateSchema(XWikiHibernateBaseStore.java:560) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.store.XWikiHibernateBaseStore.updateSchema(XWikiHibernateBaseStore.java:371) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.store.migration.hibernate.HibernateDataMigrationManager.hibernateShemaUpdate(HibernateDataMigrationManager.java:192) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.store.migration.hibernate.HibernateDataMigrationManager.updateSchema(HibernateDataMigrationManager.java:177) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.store.migration.AbstractDataMigrationManager.startMigrationsForDatabase(AbstractDataMigrationManager.java:546) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.store.migration.AbstractDataMigrationManager.startMigrations(AbstractDataMigrationManager.java:475) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.store.migration.hibernate.HibernateDataMigrationManager.startMigrations(HibernateDataMigrationManager.java:338) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.store.migration.AbstractDataMigrationManager.checkDatabase(AbstractDataMigrationManager.java:421) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.store.XWikiHibernateBaseStore.setDatabase(XWikiHibernateBaseStore.java:678) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.store.XWikiHibernateBaseStore.beginTransaction(XWikiHibernateBaseStore.java:853) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.store.XWikiHibernateBaseStore.beginTransaction(XWikiHibernateBaseStore.java:785) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.store.XWikiHibernateStore.loadXWikiDoc(XWikiHibernateStore.java:749) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.store.XWikiCacheStore.loadXWikiDoc(XWikiCacheStore.java:290) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.XWiki.getDocument(XWiki.java:1404) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.XWiki.getDocument(XWiki.java:1447) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.XWiki.getXWikiPreference(XWiki.java:2179) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.XWiki.getXWikiPreference(XWiki.java:2211) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.render.XWikiMacrosMappingRenderer.loadPreferences(XWikiMacrosMappingRenderer.java:107) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.render.XWikiMacrosMappingRenderer.<init>(XWikiMacrosMappingRenderer.java:83) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.render.DefaultXWikiRenderingEngine.<init>(DefaultXWikiRenderingEngine.java:72) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.XWiki.resetRenderingEngine(XWiki.java:1080) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.XWiki.initXWiki(XWiki.java:787) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.XWiki.<init>(XWiki.java:735) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.XWiki.getMainXWiki(XWiki.java:394) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at com.xpn.xwiki.XWiki.getXWiki(XWiki.java:483) [xwiki-platform-legacy-oldcore-4.3.jar:na]
      	at org.xwiki.wysiwyg.server.filter.XWikiContextInitializationFilter.initializeXWikiContext(XWikiContextInitializationFilter.java:134) [xwiki-platform-wysiwyg-server-4.3.jar:na]
      	at org.xwiki.wysiwyg.server.filter.XWikiContextInitializationFilter.doFilter(XWikiContextInitializationFilter.java:83) [xwiki-platform-wysiwyg-server-4.3.jar:na]
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) [catalina.jar:na]
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) [catalina.jar:na]
      	at com.xpn.xwiki.plugin.webdav.XWikiDavFilter.doFilter(XWikiDavFilter.java:66) [xwiki-platform-webdav-server-4.3.jar:na]
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) [catalina.jar:na]
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) [catalina.jar:na]
      	at org.xwiki.container.servlet.filters.internal.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:208) [xwiki-platform-container-servlet-4.3.jar:na]
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) [catalina.jar:na]
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) [catalina.jar:na]
      	at org.xwiki.container.servlet.filters.internal.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:111) [xwiki-platform-container-servlet-4.3.jar:na]
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) [catalina.jar:na]
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) [catalina.jar:na]
      	at net.bull.javamelody.MonitoringFilter.doFilter(MonitoringFilter.java:206) [javamelody-1.42.0.jar:na]
      	at net.bull.javamelody.MonitoringFilter.doFilter(MonitoringFilter.java:179) [javamelody-1.42.0.jar:na]
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) [catalina.jar:na]
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) [catalina.jar:na]
      	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) [catalina.jar:na]
      	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) [catalina.jar:na]
      	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) [catalina.jar:na]
      	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) [catalina.jar:na]
      	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) [catalina.jar:na]
      	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:263) [catalina.jar:na]
      	at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190) [tomcat-coyote.jar:na]
      	at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:283) [tomcat-coyote.jar:na]
      	at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:767) [tomcat-coyote.jar:na]
      	at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:697) [tomcat-coyote.jar:na]
      	at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:889) [tomcat-coyote.jar:na]
      	at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690) [tomcat-coyote.jar:na]
      	at java.lang.Thread.run(Thread.java:619) [na:1.6.0_12]
      2013-01-18 11:31:02,130 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  .HibernateDataMigrationManager - Running migration [R43000XWIKI6691] with version [43000] 
      2013-01-18 11:31:02,213 [http://extensions.xwiki.org/xwiki/rest/repository/extensions/org.apache.commons:commons-compress/versions/1.4.1] INFO  .HibernateDataMigrationManager - New storage version is now [43000]
      

        Attachments

          Activity

            People

            • Assignee:
              softec Denis Gervalle
              Reporter:
              vmassol Vincent Massol
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: