Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-12688

Add a "separator" parameter to the drawer extension points

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.3-milestone-1
    • Fix Version/s: 7.3-milestone-2
    • Component/s: Flamingo Skin
    • Labels:
    • Difficulty:
      Unknown
    • Similar issues:

      Description

      To add a separator before an extension point in the drawer, the UIX needs to manually call #drawerSeparator(), like the following example:

      {{velocity}}{{html clean="false"}} ## we need clean="false" because we want to display the raw content of #drawerItem()
       #template('drawer_macros.vm')
       #drawerSeparator()
       #drawerItem('someURL', 'someIcon', 'some xml-escaped text', 'some HTML id')
      {{/html}}{{/velocity}}
      

      It has the drawback that if there is no item before the UIX, the displayed separator is useless.

      We could have other problems like 2 uix defining manually a separator, but one of them do not display content because of an if, so at the end we have 2 separators in a row, etc...

      A better solution, as implemented in XWIKI-12636, is to introduce a separator parameter in the UIX and let the skin manage the separators (displaying it or not depending on the context).

      It will also be consistent with XWIKI-12636.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                gdelhumeau Guillaume Delhumeau
                Reporter:
                gdelhumeau Guillaume Delhumeau
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: