Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-15189

Panel display fails with script right error on pages on which the author of the panel doesn't have script rights

    XMLWordPrintable

Details

    • High
    • Easy
    • N/A
    • N/A

    Description

      To reproduce:

      • use a standard xwiki with the following rights:
        • admin group has view edit script admin programming everywhere
        • all group has view, edit, script everywhere
      • create a new page (subtree), let's call it "P"
      • don't configure panels for this page, let it inherit the ones from the wiki level
      • set rights for page and children: explicitly give view, edit and script only to admin group
      • with a regular user, modify one of the panels set at wiki level (for the left column, for example) - adding a comment on the panel is enough

      Expected result:

      • the panel in question still displays properly, on the Main page of the wiki and on page P

      Actual result:

      • the panel displays properly on the main page of the wiki
      • the panel displays a script right error on the page P and its subtree 
        org.xwiki.rendering.macro.MacroExecutionException: The execution of the [velocity] script macro is not allowed. Check the rights of its last author or the parameters if it's rendered from another script.
        	at org.xwiki.rendering.macro.script.AbstractScriptMacro.execute(AbstractScriptMacro.java:178)
        	at org.xwiki.rendering.macro.script.AbstractScriptMacro.execute(AbstractScriptMacro.java:58)
        	at org.xwiki.rendering.internal.transformation.macro.MacroTransformation.transform(MacroTransformation.java:272)
        	at org.xwiki.rendering.internal.transformation.DefaultRenderingContext.transformInContext(DefaultRenderingContext.java:183)
        	at org.xwiki.panels.internal.PanelWikiUIExtension.lambda$execute$0(PanelWikiUIExtension.java:169)
        	at com.xpn.xwiki.internal.security.authorization.DefaultAuthorExecutor.call(DefaultAuthorExecutor.java:85)
        	at org.xwiki.panels.internal.PanelWikiUIExtension.execute(PanelWikiUIExtension.java:166)
        	at sun.reflect.GeneratedMethodAccessor572.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:395)
        	at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:384)
        	at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:173)
        	at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280)
        	at org.apache.velocity.runtime.parser.node.ASTReference.value(ASTReference.java:567)
        	at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:151)
        	at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280)
        	at org.apache.velocity.runtime.parser.node.ASTReference.render(ASTReference.java:369)
        	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
        	at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
        	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
        	at org.apache.velocity.runtime.directive.Foreach.render(Foreach.java:420)
        	at org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
        	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
        	at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
        	at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
        	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluateInternal(DefaultVelocityEngine.java:259)
        	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:222)
        	at com.xpn.xwiki.render.DefaultVelocityManager.evaluate(DefaultVelocityManager.java:361)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.evaluateContent(InternalTemplateManager.java:790)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.render(InternalTemplateManager.java:667)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.renderFromSkin(InternalTemplateManager.java:645)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.renderFromSkin(InternalTemplateManager.java:616)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.render(InternalTemplateManager.java:602)
        	at com.xpn.xwiki.internal.template.DefaultTemplateManager.render(DefaultTemplateManager.java:77)
        	at com.xpn.xwiki.XWiki.evaluateTemplate(XWiki.java:2102)
        	at com.xpn.xwiki.XWiki.parseTemplate(XWiki.java:2080)
        	at com.xpn.xwiki.api.XWiki.parseTemplate(XWiki.java:886)
        	at sun.reflect.GeneratedMethodAccessor206.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:395)
        	at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:384)
        	at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:173)
        	at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280)
        	at org.apache.velocity.runtime.parser.node.ASTReference.render(ASTReference.java:369)
        	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
        	at org.apache.velocity.runtime.directive.VelocimacroProxy.render(VelocimacroProxy.java:216)
        	at org.apache.velocity.runtime.directive.RuntimeMacro.render(RuntimeMacro.java:311)
        	at org.apache.velocity.runtime.directive.RuntimeMacro.render(RuntimeMacro.java:230)
        	at org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
        	at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
        	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluateInternal(DefaultVelocityEngine.java:259)
        	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:222)
        	at com.xpn.xwiki.render.DefaultVelocityManager.evaluate(DefaultVelocityManager.java:361)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.evaluateContent(InternalTemplateManager.java:790)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.render(InternalTemplateManager.java:667)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.renderFromSkin(InternalTemplateManager.java:645)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.renderFromSkin(InternalTemplateManager.java:616)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.render(InternalTemplateManager.java:602)
        	at com.xpn.xwiki.internal.template.DefaultTemplateManager.render(DefaultTemplateManager.java:77)
        	at com.xpn.xwiki.XWiki.evaluateTemplate(XWiki.java:2102)
        	at com.xpn.xwiki.XWiki.parseTemplate(XWiki.java:2080)
        	at com.xpn.xwiki.api.XWiki.parseTemplate(XWiki.java:886)
        	at sun.reflect.GeneratedMethodAccessor206.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:395)
        	at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:384)
        	at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:173)
        	at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280)
        	at org.apache.velocity.runtime.parser.node.ASTReference.render(ASTReference.java:369)
        	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
        	at org.apache.velocity.runtime.directive.VelocimacroProxy.render(VelocimacroProxy.java:216)
        	at org.apache.velocity.runtime.directive.RuntimeMacro.render(RuntimeMacro.java:311)
        	at org.apache.velocity.runtime.directive.RuntimeMacro.render(RuntimeMacro.java:230)
        	at org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
        	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
        	at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
        	at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:106)
        	at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
        	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluateInternal(DefaultVelocityEngine.java:259)
        	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:222)
        	at com.xpn.xwiki.render.DefaultVelocityManager.evaluate(DefaultVelocityManager.java:361)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.evaluateContent(InternalTemplateManager.java:790)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.render(InternalTemplateManager.java:667)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.renderFromSkin(InternalTemplateManager.java:645)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.renderFromSkin(InternalTemplateManager.java:616)
        	at com.xpn.xwiki.internal.template.InternalTemplateManager.render(InternalTemplateManager.java:602)
        	at com.xpn.xwiki.internal.template.DefaultTemplateManager.render(DefaultTemplateManager.java:77)
        	at com.xpn.xwiki.XWiki.evaluateTemplate(XWiki.java:2102)
        	at com.xpn.xwiki.web.Utils.parseTemplate(Utils.java:180)
        	at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:463)
        	at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:210)
        	at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:425)
        	at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:228)
        	at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1913)
        	at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:449)
        	at javax.servlet.http.HttpServlet.service(HttpServlet.java:624)
        	at javax.servlet.http.HttpServlet.service(HttpServlet.java:731)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
        	at com.xpn.xwiki.web.ActionFilter.doFilter(ActionFilter.java:112)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
        	at org.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:127)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
        	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
        	at org.xwiki.container.servlet.filters.internal.SetHTTPHeaderFilter.doFilter(SetHTTPHeaderFilter.java:63)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
        	at org.xwiki.container.servlet.filters.internal.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:208)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
        	at org.xwiki.container.servlet.filters.internal.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:111)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
        	at org.xwiki.resource.servlet.RoutingFilter.doFilter(RoutingFilter.java:136)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
        	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:218)
        	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:110)
        	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:506)
        	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:169)
        	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
        	at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:962)
        	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
        	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:445)
        	at org.apache.coyote.ajp.AjpProcessor.process(AjpProcessor.java:190)
        	at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:637)
        	at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:316)
        	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
        

      If, at this point, the script right is unchecked on the page P (inherited from wiki), the panel is back working on the subtree P.

      Attachments

        Issue Links

          Activity

            People

              surli Simon Urli
              lucaa Anca Luca
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: