Details
-
Improvement
-
Resolution: Unresolved
-
Major
-
None
-
17.10.14, 18.8.0
-
None
-
Unknown
-
Description
The notifications and office macros produce output that the WYSIWYG editor cannot compute: the notifications are rendered asynchronously, and the office document needs a conversion server and is too heavy to show while editing. In the editor, the notifications macro shows only its "RSS Feed" link, or an empty frame, and the office macro its error or nothing useful, so the user cannot see what the macro shows.
The macros to change, with the file where most of the fix is done:
- notifications: NotificationsMacro.xml.
- office: OfficeMacro.java.
What each macro could show in the editor:
- notifications: the events themselves, by rendering the macro without asynchronous rendering when it is shown in the editor, or else a summary such as "Last 5 notifications, with the filters of the current user". XWIKI-23947 covers the asynchronous rendering in the standalone editor, which does not load the JavaScript skin extensions, but the events are missing in the in-place editor too.
- office: a frame with the icon of the file type, the name of the file and a link to it, instead of the converted document.
Depends on
- XWIKI-25523, which gives the macros a supported way to know they are rendered for the WYSIWYG editor and a shared edit-mode representation to reuse.
KOs covered
| Macro | Criterion | Problem | Depends on |
|---|---|---|---|
| notifications | E1 wysiwyg | The editor never shows the events, only the "RSS Feed" link, still after 30 seconds, in the standalone and the in-place editor, while view mode lists them; with displayRSSLink="false" it shows an empty frame. | XWIKI-25523 |
| office | E1 wysiwyg | On a fresh XWiki Standard the editor and view mode show the same office server error; with a server, the converted document is too heavy for the editor, which should rather say which file the macro views. | XWIKI-25523 |
Impact found on macro fluidity
These 2 KOs come from the WYSIWYG usability audit of the macros, under the criterion E1 wysiwyg of its usability criteria, which accepts a dedicated edit representation that keeps the meaning of the macro. The page of each macro, linked in the table, has the full notes and the steps to reproduce. Fixing them means giving each macro an edit-mode representation built on XWIKI-25523.
Attachments
Issue Links
- depends on
-
XWIKI-25523 Allow macros to provide a dedicated representation in the WYSIWYG editor
-
- Open
-
- is related to
-
XWIKI-23947 Async rendering should be disabled when the WYSIWYG editor doesn't load JavaScript skin extensions
-
- Open
-
-
XWIKI-25507 The office macro is inserted with no document and renders an error box, unlike the include and display macros
-
- Open
-