Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-25507

The office macro is inserted with no document and renders an error box, unlike the include and display macros

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Major
    • None
    • 17.10.14, 18.8.0
    • Office
    • None
    • Unknown

    Description

      When the office macro is inserted from the Quick Actions menu, an office macro call with no parameter is added to the page right away and renders an error box, since it has no document to show. The include and display macros, which also show the content of a target, declare their target as mandatory, so the Quick Action opens the Edit Macro dialog with the target field to fill first. The office macro declares neither reference nor attachment as mandatory, since it needs one of the two.

      KOs covered

      Macro Criterion Problem
      office L1 consistency No mandatory parameter, unlike include and display, so the Quick Action inserts an empty call that renders an error box.
      office I2 zero-config Quick Actions, and the Edit Macro dialog submitted with the default values, insert {{office/}}, which renders an error box in the editor and in view mode: the office server error on a fresh XWiki Standard, or "You must specify the 'reference' parameter pointing to the office file to display." The user is never asked for the file first.

      Impact found on macro fluidity

      These 2 KOs come from the WYSIWYG usability audit of the macros, under the criteria L1 consistency and I2 zero-config of its usability criteria, which checks that a macro behaves like the other macros of the same kind for the mandatory content, the insertion process and its default parameter values. The page of the macro has the full notes, and the L1 consistency table tracks the progress on this criterion.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Lucas C Charpentier Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: