XWiki Platform
  1. XWiki Platform
  2. XWIKI-7056

Not empty modal when Version Mandatory Summary is enabled

    Details

    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Similar issues:

      Description

      Steps to reproduce:

      • login
      • go to Admin Section -> Edit Mode Settings -> Enable version summary . Set this to YES
      • go to a page or create a page, and don't fill the Version Summary field.
      • click Save and View

      You will get a modal which forces you to write a summary. On IE8 and IE9, the modal windows already has the value of "undefined"

      2 remarks:

      • this is inconsistent with Firefox Browsers, which have this field blank by default. And IMO this is the correct behavior
      • we could use a xwiki type of modal, not a js one, but this is another issue.

        Issue Links

          Activity

          Hide
          Ecaterina Moraru (Valica) added a comment -

          Reproduced on XE 4.2 on FF15 (empty modal) and IE9 (undefined)

          Regarding Sorin's second remark, I suggest removing the modal and have the same behavior as when 'Title' is mandatory: marks contextually the input by using .xErrorMsg and .xErrorField, see http://platform.xwiki.org/xwiki/bin/view/DevGuide/VerticalForms#H5.Error

          Show
          Ecaterina Moraru (Valica) added a comment - Reproduced on XE 4.2 on FF15 (empty modal) and IE9 (undefined) Regarding Sorin's second remark, I suggest removing the modal and have the same behavior as when 'Title' is mandatory: marks contextually the input by using .xErrorMsg and .xErrorField, see http://platform.xwiki.org/xwiki/bin/view/DevGuide/VerticalForms#H5.Error
          Hide
          Sergiu Dumitriu added a comment -

          Fixed in a90eb78

          Show
          Sergiu Dumitriu added a comment - Fixed in a90eb78
          Hide
          Sorin Burjan added a comment -

          This fix seems to break things, because I don't get any modal at all on IE8 and IE9.

          Steps to reproduce:
          Put: Enable version summaries -> YES
          Put: Make version summaries mandatory -> YES

          Now, when saving a page you won't get any modal at all. So this seems to be a regresssion.

          Show
          Sorin Burjan added a comment - This fix seems to break things, because I don't get any modal at all on IE8 and IE9. Steps to reproduce: Put: Enable version summaries -> YES Put: Make version summaries mandatory -> YES Now, when saving a page you won't get any modal at all. So this seems to be a regresssion.

            People

            • Assignee:
              Sergiu Dumitriu
              Reporter:
              Sorin Burjan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: