Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-7754

"Page from Office" does not import images from Word documents when Filesystem attachments are used.

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 4.3-milestone-1
    • 3.2.1, 4.0-rc-1, 3.5.1
    • Office
    • None
    • Windows XP, Tomcat 6, JRE 1.6
    • Page from office, images, attachments, import
    • Unknown
    • n/a

    Description

      When attachments are stored on filesystem, "Page from Office" imports images incorrectly. Under the storage directory only ~v1.1 and ~v1.2 files are found (two created versions of the images may be also a bug). Files with current filename (without ~vX.X) is missing. This function works correctly if attachments are stored in the database.

      My xwiki.cfg contains these settings:

      xwiki.store.attachment.hint = file
      xwiki.store.attachment.versioning.hint = file
      xwiki.store.attachment.recyclebin.hint = file

      The attached docx is the document I tried to import.
      The attached zip contains the files under the "storage" folder after import is done.
      The attached screenshot contains the result of the import.

      Attachments

        1. patch.txt
          2 kB
          Guillaume Delhumeau
        2. Word_import_attachment_error.docx
          17 kB
          Daniel Marczisovszky
        3. Word_import_attachment_error.png
          32 kB
          Daniel Marczisovszky

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-7088 OpenOffice import attachment error with filsystem storage

          • Major - Major loss of function.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-8254 An attachment which is saved twice in the same transaction becomes corrupted if saved in FS attachment store.

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-8255 OpenOffice document importer saves attachments twice.

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-11519 Office Viewer not showing images of filesystem attachments

          • Major - Major loss of function.
          • Closed

          Activity

            [XWIKI-7754] "Page from Office" does not import images from Word documents when Filesystem attachments are used.
            calebjamesdelisle CalebJamesDeLisle added a comment -

            Fixed one of the 2 causal issues.

            calebjamesdelisle CalebJamesDeLisle added a comment - Fixed one of the 2 causal issues.
            calebjamesdelisle CalebJamesDeLisle added a comment -

            This issue is caused by the interaction of XWIKI-8254 and XWIKI-8255

            calebjamesdelisle CalebJamesDeLisle added a comment - This issue is caused by the interaction of XWIKI-8254 and XWIKI-8255
            vmassol Vincent Massol added a comment - - edited

            @Guillaume: Great Do you have a pull request?

            Also would be good to add some doc to explain what you did and why it's necessary (removing code duplication would also be nice).

            Then a test to prove the fix would be awesome too...

            vmassol Vincent Massol added a comment - - edited @Guillaume: Great Do you have a pull request? Also would be good to add some doc to explain what you did and why it's necessary (removing code duplication would also be nice). Then a test to prove the fix would be awesome too...
            gdelhumeau Guillaume Delhumeau added a comment -

            With the help of Caleb, I have written a patch that fix this bug.

            See patch.txt.

            gdelhumeau Guillaume Delhumeau added a comment - With the help of Caleb, I have written a patch that fix this bug. See patch.txt.
            gdelhumeau Guillaume Delhumeau added a comment -

            I have the same problem.

            The attachments are inside the filesystem, but when we try to access it through the wiki, I have the message "The attachment does not exist.".

            gdelhumeau Guillaume Delhumeau added a comment - I have the same problem. The attachments are inside the filesystem, but when we try to access it through the wiki, I have the message "The attachment does not exist.".

            People

              calebjamesdelisle CalebJamesDeLisle
              marczi Daniel Marczisovszky
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: